Skip to content

gw-field-to-field-conditional-logic.php: Fixed an issue with numeric comparison in field to field conditional logic. #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

gw-field-to-field-conditional-logic.php: Fixed an issue with numeric comparison in field to field conditional logic. #1056

merged 1 commit into from
Mar 28, 2025

Conversation

@saifsultanc
Copy link
Contributor

@saifsultanc saifsultanc commented Mar 26, 2025

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2885654688/79887

Summary

When using the Field to Field Conditional Logic snippet, if a numeric field value has thousand separators, the conditional logic works on the frontend form, but fails on submission.

Matt A's loom:
https://www.loom.com/share/c2f1e00a73044c2fb4121c9e822b550e

Loom describing the fix and quick walkthrough:
https://www.loom.com/share/dc56e01f090d4a2c81c50e7fe589f400

@saifsultanc
gw-field-to-field-conditional-logic.php: Fixed an issue with numeri…
7dd0ae0 
…c comparison in field to field conditional logic.
@coderabbitai
Copy link

coderabbitai bot commented Mar 26, 2025 •
edited
Loading

Walkthrough

The pull request introduces a new block within the modify_rule method of the GF_Field_To_Field_Conditional_Logic class. This block checks if a value is numeric using GFCommon::is_numeric and, if true, cleans the value with GFCommon::clean_number before it is used in a conditional logic rule. No changes were made to public or exported entity declarations.

Changes

File(s) Change Summary
gravity-forms/gw-field-to-field-conditional-logic.php Added logic in modify_rule to check numeric values using GFCommon::is_numeric and sanitize them using GFCommon::clean_number before comparison.

Sequence Diagram(s)

sequenceDiagram
    participant RuleModifier as modify_rule
    participant IsNumeric as GFCommon::is_numeric
    participant CleanNumber as GFCommon::clean_number

    RuleModifier->>IsNumeric: Check if value is numeric
    IsNumeric-->>RuleModifier: Return true/false
    alt Value is numeric
        RuleModifier->>CleanNumber: Clean the numeric value
        CleanNumber-->>RuleModifier: Return cleaned value
        Note over RuleModifier: Assign cleaned value to rule["value"]
    else Value is not numeric
        Note over RuleModifier: Proceed without cleaning
    end
Loading

Suggested reviewers

  • veryspry
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 183e85f and 7dd0ae0.

📒 Files selected for processing (1)
  • gravity-forms/gw-field-to-field-conditional-logic.php (1 hunks)
🔇 Additional comments (1)
gravity-forms/gw-field-to-field-conditional-logic.php (1)

268-271: Good fix for handling formatted numeric values!

This addition properly addresses the issue with numeric comparison when field values include thousand separators. Using GFCommon::clean_number() on numeric values ensures consistent comparison regardless of formatting, which fixes the conditional logic evaluation during form submission. This is a targeted and effective solution for the problem described in the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 7dd0ae0

@saifsultanc saifsultanc merged commit 7e1442a into master Mar 28, 2025
3 of 4 checks passed
@saifsultanc saifsultanc deleted the saif/fix/79887-fix-field-to-field-cl branch March 28, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veryspry veryspry veryspry approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saifsultanc @veryspry